Skip to content

Add integration test #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add integration test #230

wants to merge 1 commit into from

Conversation

@Schultzer
Copy link
Contributor

@Schultzer Schultzer commented Apr 25, 2024 •
edited
Loading

This PR adds an integration workflow for all the repositories.

This will use the current branch, SEE elixir-cldr/cldr_territories#43, for more context.

For a repository that requires ex_cldr, the mix files should change the following. This is similar to how Ecto approaches this: https://github.com/elixir-ecto/ecto_sql/blob/master/mix.exs#L53-L81

   defp deps do
     [
        {:ex_cldr, cldr_dep()},
        ...
     ]
   end


  defp cldr_dep() do
    if path = System.get_env("CLDR_PATH") do
      [path: path]
    else
      "~> 2.38"
    end
  end

@Schultzer Schultzer mentioned this pull request Apr 25, 2024
Closed
@Schultzer Schultzer force-pushed the integration-test branch 11 times, most recently from 216a46a to 77cfa6d Compare April 28, 2024 20:30
kipcole9
kipcole9 reviewed Apr 28, 2024
View reviewed changes
@Schultzer Schultzer force-pushed the integration-test branch 15 times, most recently from 05664f9 to 93938ef Compare April 29, 2024 00:34
@Schultzer Schultzer force-pushed the integration-test branch 4 times, most recently from 7b50226 to f3ad677 Compare April 29, 2024 01:05
@Schultzer Schultzer force-pushed the integration-test branch 2 times, most recently from e0c2c40 to bcac480 Compare May 16, 2024 16:53
@Schultzer Schultzer force-pushed the integration-test branch 16 times, most recently from 8e4d708 to 5979ce4 Compare June 27, 2024 22:02
@Schultzer Schultzer force-pushed the integration-test branch 4 times, most recently from 5ccef67 to 099711b Compare July 7, 2024 19:18
@Schultzer Schultzer requested a review from kipcole9 July 7, 2024 19:41
@AntoineAugusti AntoineAugusti mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LostKobrakai LostKobrakai Awaiting requested review from LostKobrakai

@kipcole9 kipcole9 Awaiting requested review from kipcole9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Schultzer @kipcole9